Re: [PATCH v2 7/9] ASoC: loongson: Add I2S controller driver as platform device

[Mark Brown <broonie@xxxxxxxxxx>]

On Tue, Sep 24, 2024 at 03:00:48PM +0800, Binbin Zhou wrote:

>  config SND_SOC_LOONGSON_I2S_PCI
>  	tristate "Loongson I2S-PCI Device Driver"
> -	select REGMAP_MMIO
>  	depends on PCI
> +	select REGMAP_MMIO
> +	select SND_SOC_LOONGSON_CARD
>  	help
>  	  Say Y or M if you want to add support for I2S driver for
>  	  Loongson I2S controller.

You shouldn't select the card from the DAI drivers, some system might
use the driver with a different card for some reason.  If anything a
select from the card to the DAI driver is more appropriate, cards are
the main user thing.

> +++ b/sound/soc/loongson/loongson_i2s_plat.c
> @@ -0,0 +1,186 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Loongson I2S controller master mode dirver(platform device)

Please use C++ style for the whole comment block so things look more
intentional.

Attachment: signature.asc
Description: PGP signature