RE: [PATCH v2 2/3] ASoC: dt-bindings: irondevice,sma1307: Add initial DT binding

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



> >
> >
> > Hi,
> >
> > I am in the process of carefully incorporating your feedback and making the
> necessary revisions.
> >
> > May I kindly ask you a question, if it's not too much trouble?
> > When running checkpatch, what would be the best way to address the following
> warning?
> >
> > WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit
> > description?)
> > #21:
> >  create mode 100644
> > Documentation/devicetree/bindings/sound/irondevice,sma1307.yaml
> >
> > In this case, would it be better for me to add a line break in the patch
> file, or should I leave it as is?
> 
> Normally I would say you can ignore this, and that checkpatch doesn't usually
> complain about the actually git output in here - but I think checkpatch
> "broke" because you did not provide any commit message body at all, so it
> starting parsing the git output instead. You need to write a body!
> 
> > WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> > #65:
> > new file mode 100644
> >
> > If the warning is appearing because it's a new file, is it something that
> can be safely ignored, or should I make changes to the MAINTAINERS file?
> >
> > Thank you for your feedback. I am learning a lot of new things!
> 
> Usually for bindings, which have maintainers listed in them, you can skip
> adding a MAINTAINERS entry.
> 
> Cheers,
> Conor.

Thank you for your answer!
I'll make sure to add a commit message next time.

I'll go over and fix the erros again.




[Index of Archives]     [Pulseaudio]     [Linux Audio Users]     [ALSA Devel]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]

  Powered by Linux