Re: [PATCH v2 1/2] ASoC: dt-bindings: cirrus,cs530x: Add initial DT binding

[Krzysztof Kozlowski <krzk@xxxxxxxxxx>]

On 14/06/2024 20:36, Paul Handrigan wrote:
> Add the YAML DT bindings for the cs530x high performance
> audio ADCs.
> 

> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        cs5304: cs5304@48 {

What happened here? This was different.

Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

audio-codec? audio-adc? adc?

Best regards,
Krzysztof