Re: [PATCH] ASoC: SOF: ipc4-topology: Add support for NHLT with 16-bit only DMIC blob

[Mark Brown <broonie@xxxxxxxxxx>]

On Wed, May 29, 2024 at 03:32:24PM +0300, Péter Ujfalusi wrote:
> On 29/05/2024 15:17, Mark Brown wrote:

> > If something is a bug fix it shouldn't have a subject saying "Add
> > support", that is very obvioulsy a new feature.  Have these systems ever
> > worked?

> Well, it is adding support for something which has never been consider
> as a valid configuration (16bit only DMIC blob in NHLT table of a laptop
> [1]).
> I have added to fixes tag to carry this patch along with the patch that
> implemented support for preferring 32bit configuration in firmware (the
> [1] would never worked, so that is unrelated).

Fixes tags are so widely abused that I don't generally pay a huge amount
of attention to them, the pattern of new features claiming to fix the
commit where something was introduced is very common.

In any case, if you're going to send a series for 6.10 I guess I'll
leave it for now.

Attachment: signature.asc
Description: PGP signature