Re: [PATCH 01/12] ALSA: hda: intel: Reduce CONFIG_PM dependencies

[Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>]

On Mon, May 06, 2024 at 06:13:44PM +0200, Takashi Iwai wrote:
> snd-hda-intel contains lots of CONFIG_PM dependent code although
> CONFIG_PM is almost mandatory nowadays, and it makes the code
> unnecessarily complex.
> 
> Let's reduce the dependencies of CONFIG_PM in snd-hda-intel driver
> code.  I left a few module options to be dependent on CONFIG_PM (which
> are visible to users), but other places are either enabled or
> optimized by compiler automatically.

...

> +static int __maybe_unused azx_resume(struct device *dev)

__maybe)unused is discouraged nowadays.
We have new PM macros (w/o SET_ prefix) along with pm_ptr() / pm_sleep_ptr()
macros. They are preferred. In complicated cases the PTR_IF() can be used
directly.

-- 
With Best Regards,
Andy Shevchenko