Re: [PATCH v3 2/2] ALSA: pcm: optimize and clarify stream sychronization ID API

[Takashi Iwai <tiwai@xxxxxxx>]

On Tue, 07 May 2024 10:26:19 +0200,
Jaroslav Kysela wrote:
> 
> +static inline void snd_pcm_set_sync(struct snd_pcm_substream *substream)
> +{
> +	substream->runtime->sync_flag = true;
> +}

This function deserves for a proper comment.  The kerndoc comment is
lost by this patch.

> @@ -1811,10 +1829,12 @@ static int snd_pcm_lib_ioctl_fifo_size(struct snd_pcm_substream *substream,
>  static int snd_pcm_lib_ioctl_sync_id(struct snd_pcm_substream *substream,
>  				     void *arg)
>  {
> -	struct snd_pcm_hw_params *params = arg;
> +	static unsigned char id[12] = { 0xff, 0xff, 0xff, 0xff,
> +					0xff, 0xff, 0xff, 0xff,
> +					0xff, 0xff, 0xff, 0xff };

This can be const.


thanks,

Takashi