Re: [PATCH v3 1/2] ALSA: pcm: reinvent the stream synchronization ID API

[Takashi Iwai <tiwai@xxxxxxx>]

On Tue, 07 May 2024 10:26:18 +0200,
Jaroslav Kysela wrote:
> +/**
> + * is sync id (clock id) empty?
> + */
> +static inline bool pcm_sync_empty(const unsigned char *sync)
> +{
> +	return get_unaligned((__u64 *)(sync + 0)) == 0 && get_unaligned((__u64 *)(sync + 8)) == 0;
> +}

This helper is needed only in one place, so we don't have to put in
the common header.  Let's move to a local place (together with
unaligned.h inclusion).


> @@ -1810,6 +1808,16 @@ static int snd_pcm_lib_ioctl_fifo_size(struct snd_pcm_substream *substream,
>  	return 0;
>  }
>  
> +static int snd_pcm_lib_ioctl_sync_id(struct snd_pcm_substream *substream,
> +				     void *arg)
> +{
> +	struct snd_pcm_hw_params *params = arg;
> +
> +	if (pcm_sync_empty(params->sync))
> +		memcpy(params->sync, &substream->runtime->sync, sizeof(params->sync));

Since sync is an array now, shouldn't we drop '&' here?


thanks,

Takashi