Re: [PATCH] ASoC: dt-bindings: renesas: Fix R-Car Gen4 SoC-specific compatibles

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



On 23/04/2024 14:19, Geert Uytterhoeven wrote:
> make dtbs_check:
> 
>     arch/arm64/boot/dts/renesas/r8a779g0-white-hawk.dtb: sound@ec5a0000: compatible: 'oneOf' conditional failed, one must be fixed:
> 	    ['renesas,rcar_sound-r8a779g0', 'renesas,rcar_sound-gen4'] is too short
> 	    ...
> 	    'renesas,rcar_sound-r8a779h0' was expected
> 
> The list of SoC-specific compatible values for R-Car Gen4 SoCs is
> mutually-exclusive, just like for other R-Car SoC generations, so it
> should use an enum.
> 
> Fixes: d6e792ed7dd022a1 ("ASoC: dt-bindings: renesas: add R8A779H0 V4M")

Offending commit was never tested (testing means dtbs_check and
dt_binding_check)... Just like many other patches from Kuninori
regarding bindings, it was not sent for automation. I don't understand
why. get_maintainers clearly asks for this...

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Best regards,
Krzysztof





[Index of Archives]     [Pulseaudio]     [Linux Audio Users]     [ALSA Devel]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]

  Powered by Linux