Re: [EXTERNAL] Re: [PATCH v7 4/4] ASoc: dt-bindings: PCM6240: Add initial DT binding

[Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>]

On 31/03/2024 15:20, Ding, Shenghao wrote:
> Hi Krzysztof
> Answer inline
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>> Sent: Sunday, March 31, 2024 4:15 PM
>> To: Ding, Shenghao <shenghao-ding@xxxxxx>; linux-kernel@xxxxxxxxxxxxxxx
>> Cc: lgirdwood@xxxxxxxxx; broonie@xxxxxxxxxx; robh+dt@xxxxxxxxxx;
>> krzysztof.kozlowski+dt@xxxxxxxxxx; conor+dt@xxxxxxxxxx; linux-
>> sound@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; perex@xxxxxxxx;
>> tiwai@xxxxxxxx; 13916275206@xxxxxxx; Chawla, Mohit
>> <mohit.chawla@xxxxxx>; soyer@xxxxxx; Huang, Jonathan
>> <jkhuang3@xxxxxx>; tiwai@xxxxxxx; Djuandi, Peter <pdjuandi@xxxxxx>;
>> Agrawal, Manisha <manisha.agrawal@xxxxxx>; Hari, Raj <s-hari@xxxxxx>;
>> Yashar, Avi <aviel@xxxxxx>; Nagalla, Hari <hnagalla@xxxxxx>; Bajjuri,
>> Praneeth <praneeth@xxxxxx>; Baojun.Xu@xxxxxxx; Rob Herring
>> <robh@xxxxxxxxxx>
>> Subject: [EXTERNAL] Re: [PATCH v7 4/4] ASoc: dt-bindings: PCM6240: Add
>> initial DT binding
>>
> .............................
>>>  - remove unneeded items and if branches.
>>>  - Add missing compatible devices, such as adc6120, etc.
>>>  - Add necessary people into the list for DTS review
>>>  - correct misaligned.
>>>  - simplify the compatibility
>>>  - remove sound-name-prefix and revert back
>>>  - Add review information
>>
>> All these changes in v7 and you still kept Rob's review? I think either review
>> was not given or your changelog is just incorrect.
> Since Rob's review, nothing changed in yaml. Even in this patch, only removed kcontrol interfaces
> in the code and added the mixer-test report in cover-letter as Mark suggested, which is no effect
> on yaml file.

Then for the future, please use some reasonable format of changelog, e.g.:
https://lore.kernel.org/all/20240210-topic-8280_pcie-v3-0-ee7af6f892a0@xxxxxxxxxx/

Best regards,
Krzysztof