Re: [PATCH v1 1/1] ASoC: soc-jack: Get rid of legacy GPIO support

[Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>]

On Mon, Mar 25, 2024 at 05:22:55PM +0000, Mark Brown wrote:
> On Mon, Mar 25, 2024 at 04:24:19PM +0200, Andy Shevchenko wrote:
> > On Mon, Mar 25, 2024 at 02:16:15PM +0000, Mark Brown wrote:
> > > On Mon, Mar 18, 2024 at 10:25:16PM +0200, Andy Shevchenko wrote:

...

> > > > If I am not mistaken, after
> > > > https://lore.kernel.org/r/20240318200804.181516-1-andriy.shevchenko@xxxxxxxxxxxxxxx
> > > > there is no more users. Hence the above is the only dependency.
> 
> > > You are mistaken, please try compile tests:

...

> > > (this is among other things in x86 allmodconfig).
> 
> > I usually enable the particular drivers and I have compile tested this,
> > but indeed, I haven't enabled _all_ modules.
> 
> > Thank you for the pointing out.
> 
> Especially if you're doing this sort of "I think I got everything" type
> change it's sensible to do at least one allmodconfig build, it won't get
> everything but it'll catch a lot.

True, as even `git grep` output can be misinterpreted and some occurrences
may disappear from the sight.

-- 
With Best Regards,
Andy Shevchenko