Re: [PATCH v1 1/1] ASoC: soc-jack: Get rid of legacy GPIO support

[Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>]

On Mon, Mar 25, 2024 at 02:16:15PM +0000, Mark Brown wrote:
> On Mon, Mar 18, 2024 at 10:25:16PM +0200, Andy Shevchenko wrote:

...

> > If I am not mistaken, after
> > https://lore.kernel.org/r/20240318200804.181516-1-andriy.shevchenko@xxxxxxxxxxxxxxx
> > there is no more users. Hence the above is the only dependency.
> 
> You are mistaken, please try compile tests:
> 
> /build/stage/linux/sound/soc/generic/simple-card-utils.c: In function ‘simple_util_init_jack’:
> /build/stage/linux/sound/soc/generic/simple-card-utils.c:755:20: error: ‘struct snd_soc_jack_gpio’ has no member named ‘gpio’
>   755 |         sjack->gpio.gpio = -ENOENT;
>       |                    ^
> 
> (this is among other things in x86 allmodconfig).

I usually enable the particular drivers and I have compile tested this,
but indeed, I haven't enabled _all_ modules.

Thank you for the pointing out.

-- 
With Best Regards,
Andy Shevchenko