Re: [PATCH] dt-bindings: i2c: Remove obsolete i2c.txt

[Rob Herring <robh@xxxxxxxxxx>]

On Thu, Feb 22, 2024 at 12:55 PM Wolfram Sang
<wsa+renesas@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> On Thu, Feb 22, 2024 at 10:43:42AM -0700, Rob Herring wrote:
> > Everything in i2c.txt is covered by schemas/i2c/i2c-controller.yaml in
> > dtschema project, so remove i2c.txt and update links to it in the tree.
> >
> > Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
>
> Differences to i2c.txt:

Thanks

> * In the schema, "clock-frequency" has a minimum of 1kHz and a maximum
>   of 3MHz. Why? The specs do not say anything about a minimum freq and
>   fastest speed mentioned in the docs is 5Mhz (Ultra fast mode).

IIRC, the high speed mode originally topped out at 3MHz. I guess
that's been revised.

We can drop the minimum.

> * new binding "i2c-scl-clk-low-timeout-us" has a description which I do
>   not understand. What is a waiting state?

Shrug. May have to look at the MPC h/w that uses the property.

>
> * new binding "no-detect" is broken. At the least, it should be named
>   something like "bus-fully-described" and then the OS can decide to
>   leave out auto-detection mechanisms. If you are interested in the
>   latter, you can simply disable class based instantiation on the host
>   controller. No need to describe this in DT.

I've reverted the property now.

Rob