Re: [PATCH] Add Asus VivoBook S 16X to quirks table for acp6x

[Geraldo Nascimento <geraldogabriel@xxxxxxxxx>]

On Mon, Feb 05, 2024 at 11:48:31AM +0800, marcel wrote:
> This patch enables microphone driver on Asus Vivobook S 16X laptop by 
> adding it to quirks table.
> 
> Signed-off-by: Marcel Geraltowski <marcelg@xxxxxxx>

Hi Marcel, thanks for the patch.

Remember to add the correct subsystem and driver name just after the
[PATCH v?] subject. While the change in and of itself is OK, you sorted
it, etc., your MUA ate the tab characters and replaced it with spaces.
This is a big no-no.

Also remember to add the maintainers to the Cc:, in this case Jaroslav
Kysela and Takashi Iwai. Failure to do that may result in unnoticed and
thus missing patches.

Thank you,
Geraldo Nascimento
> 
> - - -
> 
> --- sound/sound/soc/amd/yc/acp6x-mach.c.orig    2024-02-05 
> 10:26:11.123897233 +0800
> +++ sound/sound/soc/amd/yc/acp6x-mach.c    2024-02-05 11:04:40.554566909 
> +0800
> @@ -262,6 +262,13 @@ static const struct dmi_system_id yc_acp
>               DMI_MATCH(DMI_PRODUCT_NAME, "M5402RA"),
>           }
>       },
> +        {
> +                .driver_data = &acp6x_card,
> +                .matches = {
> +                        DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER 
> INC."),
> +                        DMI_MATCH(DMI_PRODUCT_NAME, "M5602RA"),
> +                }
> +        },
>       {
>           .driver_data = &acp6x_card,
>           .matches = {
>