Re: [EXTERNAL] Re: [PATCH v1 4/4] ASoc: dt-bindings: Create yaml file for pcm6240 codec driver

[Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>]

On 25/01/2024 08:39, Ding, Shenghao wrote:
>>
>> Why do you repeat the reg constraints? This does not seem needed.
>>
>>> +        interrupts: false
>>> +
>>> +  - if:
>>> +      properties:
>>> +        compatible:
>>> +          contains:
>>> +            enum:
>>> +              - ti,pcm3140
>>> +              - ti,pcm5140
>>> +              - ti,pcm6140
>>> +              - ti,pcmd3180
>>> +    then:
>>> +      properties:
>>> +        reg:
>>> +          description:
>>> +            I2C address, in multiple pcmdevices case, all the i2c address
>>> +            aggregate as one Audio Device to support multiple audio slots.
>>> +          maxItems: 4
>>> +          minItems: 1
>>

You did not respond to any of other comments, therefore I assume you
agree with them 100% and you will implement them fully.


>> Drop entire if
> How to convey ti,pcm1690 does not support interrupt, and others support if I remove this if

How? There is no pcm1690 here.

BTW, add missing line breaks, especially before next blocks like
additionalProperties.

>>
>>> +          items:
>>> +            minimum: 0x4c
>>> +            maximum: 0x4f
>>> +
> 
> BR
> Shenghao Ding
> 

Best regards,
Krzysztof