Re: [PATCH v5 2/3] ASoC: atmel-ssc-dai: register dai and pcm directly

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

On Tue, Nov 13, 2012 at 05:10:26PM +0800, Bo Shen wrote:
> On 11/13/2012 16:30, Mark Brown wrote:

> >Why are you changing this?  Single devices are supposed to specify -1 as
> >their id.

> This is for non-dt support, using the id to tell which ssc will be
> used to remap into audio subsystem. Maybe this is a mixed up usage,
> however I can not find good solution, any suggestions?

The machine driver should know which SSC it is using all by itself, it's
specific to a particular machine.  This is how it's been doing it since
it was written...

> This is a similar implement as 7840487cd6298f9f931103b558290d8d98d41c49

Don't quote raw commit IDs, they're not legible by humans.

> Yes, this patch is a little more than registration, however when
> change the registration method, the related code will be affected,
> so also clean up them in this patch, do I need to split this patch?

Yes, one change per patch.  Having many unrelated changes in one patch
makes it very difficult to review anything.

Attachment: signature.asc
Description: Digital signature

[Index of Archives]     [Pulseaudio]     [Linux Audio Users]     [ALSA Devel]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]

  Powered by Linux