Hey Guy ! On 19.01.24 13:05, Guy Godfroy wrote:
Also I wanted to talk a bit about the features of your exporter, maybe this discussion should be held elsewhere, let me know. You proposed the prometheus-community to adopt you exporter, which is a super cool idea. But IMHO before that you should have or plan to expose a bit more metrics. The metric list in the README contains only domain related metrics. Other exporters like tinkoff (the one I'm using) expose a bit more, I know there are metrics about pools at least. Do you plan to include more metrics in the future (volumes, volume pools, networks...)? I can understand if you need only domain related metrics but I think the other metrics should be there if this become a kinda official exporter for libvirt.
Please kindly raise an issue on GitHub [1] about this and kindly include as much detail as you can. E.g. the metric names other exporters expose and maybe some examples of how they look like for you). If there are metrics which can be easily added I don't see much of an issue doing so.
I'd also encourage you to respond to the prometheus-community issue to give this some more traction maybe.
[1] https://github.com/inovex/prometheus-libvirt-exporter [2] https://github.com/prometheus-community/community/issues/50 Regards Christian _______________________________________________ Users mailing list -- users@xxxxxxxxxxxxxxxxx To unsubscribe send an email to users-leave@xxxxxxxxxxxxxxxxx
