❦ 25 juillet 2016 06:44 CEST, Martin Kletzander <mkletzan@xxxxxxxxxx> :
> You don't need to do any of these. The connection is checked as a part
> of connection callback which we have just to de-duplicate some code in
> virsh and virt-manager. It can happen that it is checked before the
> first command and needs to be connected (or reconnected) before the next
> one. It's mostly because we allow users to do arbitrary commands that
> can change where we are connected and few other things.
>
> The errors are checked because there wasn't a close callback back then
> and it just stuck with us. Someone should remove it and at the same
> time make sure one more time close callback handles these.
Thanks for the answer! I can make a patch to remove those checks but my
tests would limited to restart libvirtd while virsh is connected. I
don't know if it's enough.
--
Make the coupling between modules visible.
- The Elements of Programming Style (Kernighan & Plauger)
_______________________________________________
libvirt-users mailing list
libvirt-users@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvirt-users
