Re: [PATCHv3 10/26] util: storagefile: Add deep copy for struct virStorageSource

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/25/2014 10:54 AM, Peter Krempa wrote:
> Now that we have pointers to store disk source information and thus can
> easily exchange the structs behind we need a function to copy all the
> data.
> ---
>  src/libvirt_private.syms  |   1 +
>  src/util/virstoragefile.c | 143 ++++++++++++++++++++++++++++++++++++++++++++++
>  src/util/virstoragefile.h |   3 +
>  3 files changed, 147 insertions(+)
> 

> +
> +
> +virStorageSourcePtr
> +virStorageSourceCopy(const virStorageSource *src,
> +                     bool backingChain)

Might be worth a doc comment for this function as well, mentioning that
driver metadata is not copied, and backingChain controls whether the
copy is shallow or deep with regards to backing files.

ACK

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]