On 06/25/2014 10:54 AM, Peter Krempa wrote: > They will be reused to transfer disk labels from snapshotted disks to > the new disk definitions. > --- > src/libvirt_private.syms | 1 + > src/util/virstoragefile.c | 45 ++++++++++++++++++++++++++++++++++++++------- > src/util/virstoragefile.h | 3 +++ > 3 files changed, 42 insertions(+), 7 deletions(-) > > +++ b/src/util/virstoragefile.c > @@ -1515,6 +1515,31 @@ virStorageSourceGetSecurityLabelDef(virStorageSourcePtr src, > } > > > +int > +virStorageSourceSeclabelsCopy(virStorageSourcePtr to, > + const virStorageSource *from) Worth a doc comment, particularly mentioning that this version replaces any existing labels in 'to' (there are other feasible semantics, such as erroring out if there are existing labels in 'to', so adding docs makes it obvious what semantics you chose without making me have to read the code). ACK once you add that. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list