On 06/18/2014 11:46 AM, Jim Fehlig wrote: >> >> In addition to extra= xm supported a root= option which was supposed >> to be incorporated into the final command line. Handle that for "virsh >> domxml-from-native xen-xm". Tested with the libxl backend. >> >> Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx> >> --- >> v2: extra should default to "". >> --- >> .gnulib | 2 +- >> >> ---> WTF. I stripped this out of the patch shown below... >> >> src/xenxs/xen_xm.c | 14 +++++++++++++- >> 2 files changed, 14 insertions(+), 2 deletions(-) >> > > ACK and pushed; thanks! I'm now seeing test failures on Fedora 20, non-xen setup: TEST: xmconfigtest 1) Xen XM-2-XML Parse paravirt-old-pvfb ... OK 2) Xen XM-2-XML Format paravirt-old-pvfb ... Offset 324 Expect [<] Actual [ <cmdline></cmdline> <] ... FAILED 3) Xen XM-2-XML Parse paravirt-old-pvfb-vncdisplay ... OK 4) Xen XM-2-XML Format paravirt-old-pvfb-vncdisplay ... Offset 324 Expect [<] Actual [ <cmdline></cmdline> <] ... FAILED 5) Xen XM-2-XML Parse paravirt-new-pvfb ... OK and several others. Looks like something in the code is outputting an empty <cmdline> element when it is not needed. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list