On Thu, Mar 20, 2014 at 14:05:15 -0600, Eric Blake wrote: > On 03/20/2014 08:42 AM, Jiri Denemark wrote: > > https://bugzilla.redhat.com/show_bug.cgi?id=1007754 > > > > When attaching a new device, we need to check if its boot order > > configuration is compatible with current domain definition. > > > > Signed-off-by: Jiri Denemark <jdenemar@xxxxxxxxxx> > > --- > > src/conf/domain_conf.c | 79 ++++++++++++++++++++++++++++++++++++++++++++++++++ > > src/conf/domain_conf.h | 1 + > > 2 files changed, 80 insertions(+) > > > > > > > +virDomainDeviceInfoPtr > > +virDomainDeviceGetInfo(virDomainDeviceDefPtr device) > > +{ > > I probably would have split this helper function into its own patch - it > may be handy in other situations, where we might want to backport just > this function and a future use of it. But the overall patch is small > enough that I don't mind keeping it as one patch to minimize your churn. It's a good idea to split it anyway so I did that. And I forgot to add the new API to libvirt_private.syms so I did that now. > ACK Split, fixed and pushed, thanks. Jirka -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list