Re: [PATCH 3/3] Check boot order on device attach

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/20/2014 08:42 AM, Jiri Denemark wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1007754
> 
> When attaching a new device, we need to check if its boot order
> configuration is compatible with current domain definition.
> 
> Signed-off-by: Jiri Denemark <jdenemar@xxxxxxxxxx>
> ---
>  src/conf/domain_conf.c | 79 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  src/conf/domain_conf.h |  1 +
>  2 files changed, 80 insertions(+)
> 

>  
> +virDomainDeviceInfoPtr
> +virDomainDeviceGetInfo(virDomainDeviceDefPtr device)
> +{

I probably would have split this helper function into its own patch - it
may be handy in other situations, where we might want to backport just
this function and a future use of it.  But the overall patch is small
enough that I don't mind keeping it as one patch to minimize your churn.

ACK

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]