Re: [PATCH 4/7] Don't leave empty first line in C source files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/17/2014 08:39 AM, Martin Kletzander wrote:
> If there should be some sort of separator it is better to use comment
> with the filename, copyright, description, license information and
> authors.
> 
> Found by:
> 
> git grep -nH '^$' | grep '\.[ch]:1:'
> 
> Signed-off-by: Martin Kletzander <mkletzan@xxxxxxxxxx>
> ---
> 
> Notes:
>     If any reviewer wants I can add a syntax-check for that.

Yes, that would be a nice followup.  We already have a check for
trailing blank lines; can that check be extended to also cover leading
blank lines?


> +++ b/tests/xml2sexprtest.c
> @@ -1,4 +1,3 @@
> -
>  #include <config.h>
> 

ACK

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]