Just getting rid of my local 'cleanup' branch. Some are trivial, but every patch should be able to work on its own, I'm sending it in a series not to mess up the list. Martin Kletzander (7): qemu: agent availability cleanup tests: cleanup object-locking test Fix inconsistency in using curly braces around functions Don't leave empty first line in C source files Explicitly cast some switch parameters to enum Remove duplicate network model characters Require spaces around equality comparisons .gitignore | 6 +- build-aux/bracket-spacing.pl | 9 +- daemon/libvirtd-config.c | 5 +- docs/internals/command.html.in | 3 +- examples/dominfo/info1.c | 7 +- src/conf/domain_conf.c | 30 ++-- src/conf/domain_nwfilter.c | 13 +- src/conf/interface_conf.c | 54 ++++--- src/conf/nwfilter_conf.c | 21 ++- src/conf/nwfilter_params.c | 3 +- src/esx/esx_device_monitor.c | 1 - src/esx/esx_device_monitor.h | 1 - src/esx/esx_driver.c | 1 - src/esx/esx_driver.h | 1 - src/esx/esx_interface_driver.c | 1 - src/esx/esx_interface_driver.h | 1 - src/esx/esx_network_driver.c | 1 - src/esx/esx_network_driver.h | 1 - src/esx/esx_nwfilter_driver.c | 1 - src/esx/esx_nwfilter_driver.h | 1 - src/esx/esx_private.h | 1 - src/esx/esx_secret_driver.c | 1 - src/esx/esx_secret_driver.h | 1 - src/esx/esx_storage_backend_iscsi.c | 1 - src/esx/esx_storage_backend_iscsi.h | 1 - src/esx/esx_storage_backend_vmfs.c | 1 - src/esx/esx_storage_backend_vmfs.h | 1 - src/esx/esx_storage_driver.c | 1 - src/esx/esx_storage_driver.h | 1 - src/esx/esx_util.c | 1 - src/esx/esx_vi.c | 1 - src/esx/esx_vi.h | 1 - src/esx/esx_vi_methods.c | 1 - src/esx/esx_vi_methods.h | 1 - src/esx/esx_vi_types.c | 1 - src/esx/esx_vi_types.h | 1 - src/hyperv/hyperv_device_monitor.c | 1 - src/hyperv/hyperv_device_monitor.h | 1 - src/hyperv/hyperv_driver.c | 1 - src/hyperv/hyperv_driver.h | 1 - src/hyperv/hyperv_interface_driver.c | 1 - src/hyperv/hyperv_interface_driver.h | 1 - src/hyperv/hyperv_network_driver.c | 1 - src/hyperv/hyperv_network_driver.h | 1 - src/hyperv/hyperv_nwfilter_driver.c | 1 - src/hyperv/hyperv_nwfilter_driver.h | 1 - src/hyperv/hyperv_private.h | 1 - src/hyperv/hyperv_secret_driver.c | 1 - src/hyperv/hyperv_secret_driver.h | 1 - src/hyperv/hyperv_storage_driver.c | 1 - src/hyperv/hyperv_storage_driver.h | 1 - src/hyperv/hyperv_util.c | 1 - src/hyperv/hyperv_util.h | 1 - src/hyperv/hyperv_wmi.c | 1 - src/hyperv/hyperv_wmi.h | 1 - src/hyperv/hyperv_wmi_classes.c | 1 - src/hyperv/hyperv_wmi_classes.h | 1 - src/hyperv/openwsman.h | 1 - src/interface/interface_backend_netcf.c | 5 +- src/libvirt.c | 2 +- src/libxl/libxl_driver.c | 3 +- src/locking/lock_driver_sanlock.c | 4 +- src/lxc/lxc_driver.c | 27 ++-- src/network/bridge_driver.c | 45 ++++-- src/nwfilter/nwfilter_driver.c | 26 ++-- src/nwfilter/nwfilter_learnipaddr.c | 38 +++-- src/openvz/openvz_conf.c | 15 +- src/openvz/openvz_driver.c | 42 ++++-- src/qemu/qemu_agent.c | 5 +- src/qemu/qemu_command.c | 16 ++- src/qemu/qemu_domain.c | 22 +++ src/qemu/qemu_domain.h | 4 + src/qemu/qemu_driver.c | 193 +++++++++----------------- src/qemu/qemu_migration.c | 4 +- src/qemu/qemu_monitor.c | 3 +- src/qemu/qemu_monitor_json.c | 3 +- src/qemu/qemu_monitor_text.c | 17 ++- src/rpc/virnetclient.c | 10 +- src/rpc/virnetserver.c | 8 +- src/rpc/virnetserverclient.c | 5 +- src/rpc/virnettlscontext.c | 5 +- src/secret/secret_driver.c | 8 +- src/security/security_stack.c | 5 +- src/security/virt-aa-helper.c | 1 - src/storage/storage_backend_fs.c | 12 +- src/storage/storage_driver.c | 72 ++++++---- src/test/test_driver.c | 135 ++++++++++++------ src/uml/uml_driver.c | 69 ++++++--- src/util/vircgroup.c | 12 +- src/util/virconf.c | 5 +- src/util/virdbus.c | 8 +- src/util/virerror.c | 3 +- src/util/vireventpoll.c | 20 ++- src/util/virhook.c | 8 +- src/util/virrandom.c | 5 +- src/util/virsocketaddr.c | 26 ++-- src/util/virthread.c | 5 +- src/util/virthreadpool.c | 3 +- src/util/virutil.c | 17 ++- src/util/viruuid.c | 5 +- src/vbox/vbox_MSCOMGlue.c | 1 - src/vbox/vbox_MSCOMGlue.h | 1 - src/vbox/vbox_glue.c | 1 - src/vbox/vbox_glue.h | 1 - src/vbox/vbox_tmpl.c | 179 ++++++++++++++++-------- src/vmx/vmx.h | 1 - src/xen/xen_driver.c | 6 +- src/xen/xm_internal.c | 8 +- src/xenapi/xenapi_driver.c | 4 +- src/xenapi/xenapi_utils.c | 5 +- src/xenxs/xen_xm.c | 32 +++-- tests/Makefile.am | 12 +- tests/commandhelper.c | 5 +- tests/commandtest.c | 2 +- tests/domainsnapshotxml2xmltest.c | 2 +- tests/interfacexml2xmltest.c | 2 +- tests/libvirtdconftest.c | 4 +- tests/lxcxml2xmltest.c | 2 +- tests/networkxml2conftest.c | 2 +- tests/networkxml2xmltest.c | 2 +- tests/nodedevxml2xmltest.c | 2 +- tests/nodeinfotest.c | 2 +- tests/nwfilterxml2xmltest.c | 2 +- tests/{object-locking.ml => objectlocking.ml} | 10 +- tests/qemuargv2xmltest.c | 5 +- tests/qemuxml2argvtest.c | 2 +- tests/qemuxml2xmltest.c | 2 +- tests/qemuxmlnstest.c | 2 +- tests/sexpr2xmltest.c | 2 +- tests/sockettest.c | 4 +- tests/statstest.c | 2 +- tests/storagepoolxml2xmltest.c | 2 +- tests/storagevolxml2argvtest.c | 2 +- tests/storagevolxml2xmltest.c | 2 +- tests/testutils.c | 6 +- tests/testutilslxc.h | 1 - tests/testutilsxen.h | 1 - tests/virauthconfigtest.c | 4 +- tests/virbuftest.c | 2 +- tests/vircgrouptest.c | 2 +- tests/virdbustest.c | 4 +- tests/virdrivermoduletest.c | 4 +- tests/virhostdevtest.c | 2 +- tests/viridentitytest.c | 4 +- tests/virkeyfiletest.c | 4 +- tests/virkmodtest.c | 2 +- tests/virlockspacetest.c | 4 +- tests/virnetmessagetest.c | 4 +- tests/virnetsockettest.c | 2 +- tests/virnettlscontexttest.c | 4 +- tests/virnettlssessiontest.c | 4 +- tests/virpcitest.c | 4 +- tests/virportallocatortest.c | 2 +- tests/virshtest.c | 56 +++++--- tests/virstringtest.c | 5 +- tests/virsystemdtest.c | 4 +- tests/virtimetest.c | 4 +- tests/viruritest.c | 4 +- tests/virusbtest.c | 3 +- tests/xencapstest.c | 35 +++-- tests/xmconfigtest.c | 4 +- tests/xml2sexprtest.c | 3 +- tools/virsh-domain-monitor.c | 2 +- tools/virsh-pool.c | 2 +- 164 files changed, 936 insertions(+), 679 deletions(-) rename tests/{object-locking.ml => objectlocking.ml} (98%) -- 1.9.0 -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list