On 12/20/2013 10:53 AM, Reco wrote: >> At any rate, since Dan has ack'ed it, and it fixes a CVE (where we're >> still waiting for the number to be assigned, but the flaw is real), I'll >> go ahead and push this soon. > > Thank you for the advices, Eric, sorry I didn't followed'em to the > letter. It wasn't intentional, I just don't have that much experience > with git. That's okay - you've already shown great initiative by reporting _and fixing_ a security bug. Getting all the details right comes with time and experience, but we all have to start somewhere. If you read HACKING, but found things confusing or lacking, let us know - we'd like to improve it for the next first-time contributor. If you didn't read HACKING, then that might explain why it took a few tries to come up to speed on our conventions. > > It's good to know that these small patches benefited the Libvirt > project. > > Reco You still haven't answered my query from an earlier version: we prefer to list a legal name in the authorship of git commits (after all, copyleft licenses work _because_ of copyright law, but the law prefers working with full names rather than nicknames). Is there something that I should list you as rather than just "Reco"? -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list