Hi. On Fri, 20 Dec 2013 10:48:39 -0700 Eric Blake <eblake@xxxxxxxxxx> wrote: > On 12/20/2013 09:24 AM, Reco wrote: > > Implement virProcessRunInMountNamespace, which runs callback of type > > virProcessNamespaceCallback in a container namespace. > > > > Hope it'll nail it this time. > > This comment doesn't fit in the commit message; it's better to put > review comments... > > > > > --- > > ...here, after the '---' separator, so that 'git am' will strip the > information that was useful to reviewers, but not to overall history. > For the same reason, your patch should be titled: > > [PATCHv4 1/2] ... > > and not > > [PATCH 1/2] ... v4 > > since v4 means nothing in libvirt.git (where we don't see the earlier > three versions), but only on the mailing list. > > Also, when sending a series, it's better to stick both 1/2 and 2/2 as > in-reply-to a 0/2 cover letter. > > You can do all that with: > git send-email -2 --cover-letter --subject-prefix=PATCHv4 > > At any rate, since Dan has ack'ed it, and it fixes a CVE (where we're > still waiting for the number to be assigned, but the flaw is real), I'll > go ahead and push this soon. Thank you for the advices, Eric, sorry I didn't followed'em to the letter. It wasn't intentional, I just don't have that much experience with git. It's good to know that these small patches benefited the Libvirt project. Reco -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list