On 12/04/2013 03:30 AM, Michal Privoznik wrote:
>>
>> An alternative might be to use a pipe back to the parent, marked
>> close-on-exec, where we dump any untranslated error messages (the parent
>> can then read until EOF, and if it gets anything on the pipe, then we
>> know the child raised an error). Doing so is probably a good idea
>> anyways, as printing into the log file in the child process is dangerous
>> (if the child uses _("...") to translate an error message, then it is
>> calling a function that is not async-signal-safe, and could deadlock).
>> But it's more invasive, and is not written, so your approach is find to
>> use in the meantime.
>
> Does this mean ACK with grammar fixed? :)
Now that I've slept on the question, yes:
ACK.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list