On 12/02/2013 09:39 AM, Cédric Bosdonnat wrote:
> This aims at providing some consistency with other domain events
> ---
>
> -virDomainEventPtr virDomainEventNew(int id, const char *name,
> +virDomainEventPtr virDomainEventLifecycleNew(int id, const char *name,
> const unsigned char *uuid,
> int type, int detail)
Indentation is now off on this and several other lines. I know this got
pushed, so it's probably worth a followup patch to clean up inconsistent
indentation.
> {
> @@ -808,19 +808,21 @@ virDomainEventPtr virDomainEventNew(int id, const char *name,
> return (virDomainEventPtr)event;
> }
>
> -virDomainEventPtr virDomainEventNewFromDom(virDomainPtr dom, int type, int detail)
> +virDomainEventPtr virDomainEventLifecycleNewFromDom(virDomainPtr dom, int type, int detail)
Also, this made a long line even longer; our style has been gradually
switching over to:
virDomainEventPtr
virDomainEventLifecycleNewFromDom(virDomainPtr dom,
int type,
int detail)
{
to avoid the long lines.
> - event = virDomainEventNewFromObj(vm, VIR_DOMAIN_EVENT_STOPPED,
> + event = virDomainEventLifecycleNewFromObj(vm, VIR_DOMAIN_EVENT_STOPPED,
> VIR_DOMAIN_EVENT_STOPPED_DESTROYED);
More examples of indentation changes needed.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list