Michal Privoznik wrote: > On 06.12.2013 00:36, Jim Fehlig wrote: > >> This series moves some driver-specific files from the main libvirt-daemon >> package to the respective libvirt-daemon-driver-* package when building with >> driver modules. >> >> This was originally all one patch that I found difficult to review, so I tried >> to logically break it up in hopes to make it easier to review. >> >> Jim Fehlig (6): >> spec: Conditionally add /etc/libvirt/nwfilter >> spec: Only add libvirt-daemon pre install script if building with qemu spec: Fix files list when building without driver modules >> spec: Conditionally specify some hypervisor-specific files >> spec: Define hypervisor-specific files together >> spec: move driver-specific files to driver subpackages >> >> libvirt.spec.in | 199 +++++++++++++++++++++++++++++++++----------------------- >> 1 file changed, 117 insertions(+), 82 deletions(-) >> >> > > ACK series but see my comment to 1/6. > Yep, saw that and reposted the patch, which Eric ACK'ed. I've tested full, client-only, and without modules builds on my SUSE-ized version of the spec file after applying this series. I didn't notice any problems, but find it hard to believe I didn't botch something with all of these changes :). But it is early enough in the release cycle to find and cleanup anything I missed, so I pushed the series. Thanks Michal, Eric, and Daniel for the reviews! Regards, Jim -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list