On Thu, Dec 05, 2013 at 09:15:15AM -0700, Jim Fehlig wrote: > Daniel P. Berrange wrote: > > On Tue, Dec 03, 2013 at 03:30:08PM -0700, Jim Fehlig wrote: > > > >> The libvirt-daemon package contains several hypervisor-specific files, > >> directories, and script, which can be problematic when building the > >> package with multiple hypervisor support, e.g. both QEMU and Xen. > >> > >> E.g. installing a QEMU+Xen enabled libvirt-daemon on a Xen-only system > >> will result in the creation of qemu and kvm groups and a qemu user. > >> > >> Move the hypervisor-specific files, directories, and script to the > >> respective hypervisor driver subpackages. > >> --- > >> libvirt.spec.in | 117 ++++++++++++++++++++++---------------------------------- > >> > > > > Mostly looks good, but how about the dirs related to the libvirt-daemon-driver-network RPM - they're still in the main RPM and could be moved too. > > > > While doing that, noticed that all the libvirt-daemon-driver-* are > conditional on 'with_driver_modules'. So it seems these files, > directories, etc are needed in the main RPM when not building driver > modules, but in the subpackages when building driver modules? Hmm, not > sure if that is correct... Oh, of course. That'll be why i left them in the main libvirt-daemon RPM. Guess we'll need to make the this change conditional on the with_driver_modules flag. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list