Re: [PATCH 1/3] add percentage limit parse and define support for RAM filesystems

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> -----Original Message-----
> From: libvir-list-bounces@xxxxxxxxxx
[mailto:libvir-list-bounces@xxxxxxxxxx]
> >
> > On Thu, Nov 28, 2013 at 05:14:43PM +0800, Chen Hanxiao wrote:
> > > From: Chen Hanxiao <chenhanxiao@xxxxxxxxxxxxxx>
> > >
> > > This patch enables percentage limit for ram filesystem
> > >
> > > <filesystem type='ram'>
> > >     <source usage='10%'/>
> > >     <target dir='/mnt'/>
> > > </filesystem>
> > >
> > > Percentage limit would have more priority than size limit.
> > >
> > > Signed-off-by: Chen Hanxiao <chenhanxiao@xxxxxxxxxxxxxx>
> > > ---
> > >  src/conf/domain_conf.c | 21 +++++++++++++++++----
> > >  src/conf/domain_conf.h |  1 +
> > >  2 files changed, 18 insertions(+), 4 deletions(-)
> >
> > I'm not really convinced we need this feature. Seems like more code for
> > little real benefit.
> >
> 
> I think we should follow the style of mount(8). It accepted this style.
> 
> And this feature could bring us convenience in config, free us from
counting the
> size.
> 
> Thanks.

Hi Daniel

	Do we really don't need this feature? Or we may need some code
optimization?

Thanks.




--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]