Re: [PATCH 4/5] domainsnapshotxml2xmltest: Add existing files as new tests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/04/2013 10:55 AM, Peter Krempa wrote:
> There were plenty snapshot XMLs in the tests/domainsnapshotxml2xmlin
> directory that actually weren't used in XML testing. The upgraded
> domainsnapshotxml2xml test now allows us to use them.

They WERE used in domainsnapshotschematest, for RNG validation, but I
agree that enhancing the xml2xml test to also test them through the C
code and not just RNG validation is a good move.

> ---
>  tests/domainsnapshotxml2xmlin/external_vm.xml           |  1 -
>  tests/domainsnapshotxml2xmlin/noparent.xml              |  1 +
>  tests/domainsnapshotxml2xmlout/disk_snapshot.xml        | 15 +++++++++++++++
>  tests/domainsnapshotxml2xmlout/empty.xml                |  8 ++++++++
>  tests/domainsnapshotxml2xmlout/external_vm.xml          |  5 +++++
>  tests/domainsnapshotxml2xmlout/name_and_description.xml |  5 +++++
>  tests/domainsnapshotxml2xmlout/noparent.xml             |  2 +-
>  tests/domainsnapshotxml2xmltest.c                       | 10 ++++++++++
>  8 files changed, 45 insertions(+), 2 deletions(-)
>  create mode 100644 tests/domainsnapshotxml2xmlout/disk_snapshot.xml
>  create mode 100644 tests/domainsnapshotxml2xmlout/empty.xml
>  create mode 100644 tests/domainsnapshotxml2xmlout/external_vm.xml
>  create mode 100644 tests/domainsnapshotxml2xmlout/name_and_description.xml
> 

ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]