Re: [PATCH python 04/15] generator: Cast iterators to a list() explicitly

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/03/2013 09:36 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange@xxxxxxxxxx>
> 
> In python3 various methods list 'dict.keys()' do not
> return a list, so we must explicitly cast the result.
> 
> Signed-off-by: Daniel P. Berrange <berrange@xxxxxxxxxx>
> ---
>  generator.py | 40 ++++++++++++++++++++--------------------
>  1 file changed, 20 insertions(+), 20 deletions(-)
> 
> diff --git a/generator.py b/generator.py
> index 23bae9a..ce2797e 100755
> --- a/generator.py
> +++ b/generator.py
> @@ -603,7 +603,7 @@ def print_function_wrapper(module, name, output, export, include):
>          print("failed to get function %s infos" % name)
>          return
>  
> -    if skipped_modules.has_key(module):
> +    if module in skipped_modules:
>          return 0

This hunk belongs in 5/15

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]