Re: [PATCH 4/5] bridge_driver: Resolve Coverity CHECKED_RETURN warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/03/2013 07:18 AM, John Ferlan wrote:
> The networkRegister() didn't check the return status of the
> virRegisterNetworkDriver() call like other callers, so just
> check and handle here as well.
> 
> Signed-off-by: John Ferlan <jferlan@xxxxxxxxxx>
> ---
>  src/network/bridge_driver.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

ACK

> 
> diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c
> index 1e4cc70..80c5acb 100644
> --- a/src/network/bridge_driver.c
> +++ b/src/network/bridge_driver.c
> @@ -3046,7 +3046,8 @@ static virStateDriver networkStateDriver = {
>  };
>  
>  int networkRegister(void) {
> -    virRegisterNetworkDriver(&networkDriver);
> +    if (virRegisterNetworkDriver(&networkDriver) < 0)
> +        return -1;
>      virRegisterStateDriver(&networkStateDriver);
>      return 0;
>  }
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]