Re: [PATCH 1/5] nwfilter: Remove Coverity DEADCODE warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/03/2013 07:18 AM, John Ferlan wrote:
> The nwfilterStateInitialize() would only assign sysbus inside
> a WITH_DBUS conditional, thus leavin a subsequent check for sysbus

s/leavin/leaving/

> and nwfilterDriverInstallDBusMatches() as a no-op
> 
> Rather than try to add WITH_DBUS conditions which ended up conflicting
> with the usage of HAVE_FIREWALLD conditionals, just remove the WITH_DBUS
> since virdbus.c has entry points for with and without conditions.
> 
> Signed-off-by: John Ferlan <jferlan@xxxxxxxxxx>
> ---
>  src/nwfilter/nwfilter_driver.c | 2 --
>  1 file changed, 2 deletions(-)

ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]