On 12/03/2013 08:59 AM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" <berrange@xxxxxxxxxx> > > If an app used the virDomainEventRegister binding instead > of the virDomainEventRegisterAny binding, it would never > have its callback invoked. This is because the code for > dispatching from the C libvirt_virConnectDomainEventCallback > method was totally fubar. > > If DEBUG macro was set in the python build the error would > become visible > > "libvirt_virConnectDomainEventCallback dom_class is not a class!" > > The code in libvirt_virConnectDomainEventCallback was > inexplicably complex and has apparently never worked. The > fix is to write it the same way as the other callback handlers. > > Signed-off-by: Daniel P. Berrange <berrange@xxxxxxxxxx> > --- > libvirt-override-virConnect.py | 2 +- > libvirt-override.c | 64 ++++-------------------------------------- > 2 files changed, 6 insertions(+), 60 deletions(-) ACK. Wow - that was a LOT of cruft. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list