On Fri, Nov 29, 2013 at 05:21:21PM +0000, Daniel P. Berrange wrote:
> On Fri, Nov 29, 2013 at 04:19:01PM +0100, Cédric Bosdonnat wrote:
> > ---
> > src/conf/domain_event.c | 102 ++++++++++++++++++++++++++++--------------------
> > 1 file changed, 59 insertions(+), 43 deletions(-)
> >
> > diff --git a/src/conf/domain_event.c b/src/conf/domain_event.c
> > index b0c9050..0c38352 100644
> > --- a/src/conf/domain_event.c
> > +++ b/src/conf/domain_event.c
> > @@ -79,6 +79,8 @@ struct _virObjectEventCallback {
> >
> >
> > static virClassPtr virObjectEventClass;
> > +static virClassPtr virClassForObjectEvent(void);
> > +
> > static virClassPtr virDomainEventLifecycleClass;
> > static virClassPtr virDomainEventRTCChangeClass;
> > static virClassPtr virDomainEventWatchdogClass;
> > @@ -211,62 +213,76 @@ static int virObjectEventOnceInit(void)
> > sizeof(virObjectEvent),
> > virObjectEventDispose)))
> > return -1;
> > + return 0;
> > +}
> > +
> > +VIR_ONCE_GLOBAL_INIT(virObjectEvent)
>
> Not sure I see the reason for have separate global initializers
> here. Feels like a single global initializers for all types of
> events should be fine. A single process is ultimately going to
> need all of them..
Oh ignore me. I should have remembered that I suggested splitting
this into two separate source files.
ACK
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list