Re: [PATCH 3/3] Fix bug in identifying sub-mounts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/27/2013 09:31 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange@xxxxxxxxxx>
> 
> The code for extracting sub-mounts would just do a STRPREFIX
> check on the mount. This was flawed because if there were
> the following mounts
> 
>  /etc/aliases
>  /etc/aliases.db
> 
> and '/etc/aliases' was asked for, it would return both even
> though the latter isn't a sub-mount.
> 
> Signed-off-by: Daniel P. Berrange <berrange@xxxxxxxxxx>
> ---

ACK

(hmm, I remember pointing out the STRPREFIX issue on a different patch:
https://www.redhat.com/archives/libvir-list/2013-September/msg00657.html; I
guess that means we have checked for a prefix directory in more than one
instance - worth factoring it into a helper function?)

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]