Re: [PATCH 1/3] Remove 'abs_srcdir' variable from test files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/27/2013 09:31 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange@xxxxxxxxxx>
> 
> Define 'abs_srcdir' in AM_CFLAGS, just as we do for 'abs_builddir'.
> This lets test files write code like
> 
>    abs_srcdir "/some/file"
> 
> and thus avoid the tedium of virAsprintf() to build paths in some
> places.
> 
> Signed-off-by: Daniel P. Berrange <berrange@xxxxxxxxxx>
> ---
>  tests/Makefile.am  |  1 +
>  tests/testutils.c  | 12 ------------
>  tests/testutils.h  |  1 -
>  tests/virpcimock.c |  5 -----
>  4 files changed, 1 insertion(+), 18 deletions(-)

Oh my.  I just independently implemented this and pushed it in an effort
to solve virpcitest failures!

NACK, on the grounds that it is obsolete :)

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]