Re: [PATCH] qemu: fix well-formed migration URI formatting

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/22/2013 10:15 PM, Michael Chapman wrote:
> When adding an automatically allocated port to a well-formed migration
> URI, keep it well-formed:
> 
>   tcp://1.2.3.4/  ->  tcp://1.2.3.4/:12345   # wrong
>   tcp://1.2.3.4/  ->  tcp://1.2.3.4:12345/   # fixed
>   tcp://1.2.3.4   ->  tcp://1.2.3.4:12345    # still works
>   tcp:1.2.3.4     ->  tcp:1.2.3.4:12345      # still works (old syntax)
> 
> Signed-off-by: Michael Chapman <mike@xxxxxxxxxxxxxxxxx>
> ---
>  src/qemu/qemu_migration.c | 16 +++++++++++++---
>  1 file changed, 13 insertions(+), 3 deletions(-)
> 

Apologies for the slow review time.

ACK and pushed.  A testsuite addition would also be nice, to prove we
don't regress...

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]