On Wed, 23 Oct 2013, Michael Chapman wrote:
When adding an automatically allocated port to a well-formed migration
URI, keep it well-formed:
tcp://1.2.3.4/ -> tcp://1.2.3.4/:12345 # wrong
tcp://1.2.3.4/ -> tcp://1.2.3.4:12345/ # fixed
tcp://1.2.3.4 -> tcp://1.2.3.4:12345 # still works
tcp:1.2.3.4 -> tcp:1.2.3.4:12345 # still works (old syntax)
Hi,
I was wondering if anyone has had a chance to look at this patch.
It's pretty straight-forward, just making sure that
qemuMigrationPrepareDirect doesn't return a malformed migration URI when
the one supplied doesn't have an explicit port number.
without this patch, if the user supplies a well-formed tcp://<ip>/
migration URI without a port, QEMU on the source side of the migration is
told to connect to the target on port 0, which obviously doesn't work too
well.
Regards,
Michael
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list