On 10/08/2013 03:43 AM, Michal Privoznik wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=994364 > > If user provides domain XML in migration we check if it doesn't break > ABI via virDomainDefCheckABIStability(). However, if the provided XML > was generated via virDomainGetXMLDesc(..., VIR_DOMAIN_XML_MIGRATABLE) > it is missing some devices, e.g. 'pci-root' controller. Hence, the ABI > stability check fails even though it is stable. > > Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx> > --- > src/qemu/qemu_migration.c | 41 +++++++++++++++++++++++++++++++++-------- > 1 file changed, 33 insertions(+), 8 deletions(-) Oh my. How many different ways is this going to bite us? Is it worth fixing virDomainDefCheckABIStability to do the sanitization itself, instead of making every single caller across multiple patches repeat the work? What you have seems to work, but I'm really starting to wonder if it is the best patch. Weak ACK. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list