Bamvor Jian Zhang wrote:
> Hi, Jim
>
> thanks your reply. one comment below.
>
> >>>已写入 "Jim Fehlig <jfehlig@xxxxxxxx>"> On 07/04/2013 05:58 AM, Bamvor Jian Zhang wrote:
>
>> BTW, do all of these types work with Xen? I've only tested with type 'pty',
>>
>> which works fine with both pv and hvm guests.
>>
> i only test the pty type too. lots of type is introduced in 2b84e445(Add libxenlight driver), i add the missing type compare with qemu driver. maybe it will be used in future. for now, only pty is needed for my console patch.
>
I found some time today to test type={unix,tcp,file,udp} and they seem
to work fine with Xen 4.3, but HVM guests only. I suppose that is
expected since qemu is not being used for serial ports for PV guests.
Can you fix all my previous comments, rebase the patch, and send a V2?
Oh, and one more thing...
> @@ -4739,6 +4857,7 @@ static virDriver libxlDriver = {
> .domainManagedSave = libxlDomainManagedSave, /* 0.9.2 */
> .domainHasManagedSaveImage = libxlDomainHasManagedSaveImage, /* 0.9.2 */
> .domainManagedSaveRemove = libxlDomainManagedSaveRemove, /* 0.9.2 */
> + .domainOpenConsole = libxlDomainOpenConsole, /* 1.0.8 */
> .domainIsActive = libxlDomainIsActive, /* 0.9.0 */
> .domainIsPersistent = libxlDomainIsPersistent, /* 0.9.0 */
> .domainIsUpdated = libxlDomainIsUpdated, /* 0.9.0 */
AFAIK, the next release will be 1.1.1.
Regards,
Jim
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list