On 07/11/2013 07:55 PM, John Ferlan wrote: > This patch set replaces: > > https://www.redhat.com/archives/libvir-list/2013-July/msg00435.html > > Changes > > 01 -> No change > 02 & 03 -> Adjust typecaste to switch() and remove "default:" > 04 -> Use "unsigned int" as requested > 05 -> Add ballooninit, remove get of period before set, remove > setting of period during reconnect, other changes per review > 06 -> Remove the opaque structure, replace with direct call through > "qom-get" to return "guest-stats" and fill in stats[] directly > 07 -> 09-> Remove the "flags", "Flags", "FLAGS" (learned something new!) > 10 -> Add virsh.pod (hopefully have syntax right). > NOTE: The formatdomain.html.in was already updated in 04 to > describe the <stats period='#'/> XML syntax. This change > describes the virsh command in order to set the period since > this is the change where virsh code was adjusted. In 04, all > one could do would be virsh edit > > John Ferlan (10): > Add qemuMonitorJSONGetObjectListPaths() method for QMP qom-list > command > Add qemuMonitorJSONGetObjectProperty() method for QMP qom-get command > Add qemuMonitorJSONSetObjectProperty() method for QMP qom-set command > Add 'period' for Memballoon statistics gathering capability > Determine whether to start balloon memory stats gathering. > Add capability to fetch balloon stats > Add new public API virDomainSetMemoryStatsPeriodFlags > Specify remote protocol for virDomainSetMemoryStatsPeriodFlags > Implement the virDomainSetMemoryStatsPeriodFlags for QEMU driver > Allow balloon driver collection to be adjusted dynamically > > docs/formatdomain.html.in | 19 ++ > docs/schemas/domaincommon.rng | 7 + > include/libvirt/libvirt.h.in | 3 + > src/conf/domain_conf.c | 38 +++- > src/conf/domain_conf.h | 1 + > src/driver.h | 6 + > src/libvirt.c | 64 ++++++ > src/libvirt_public.syms | 5 + > src/qemu/qemu_driver.c | 65 ++++++ > src/qemu/qemu_monitor.c | 140 ++++++++++++- > src/qemu/qemu_monitor.h | 2 + > src/qemu/qemu_monitor_json.c | 460 ++++++++++++++++++++++++++++++++---------- > src/qemu/qemu_monitor_json.h | 60 ++++++ > src/qemu/qemu_process.c | 14 +- > src/remote/remote_driver.c | 1 + > src/remote/remote_protocol.x | 15 +- > src/remote_protocol-structs | 6 + > tests/qemumonitorjsontest.c | 186 +++++++++++++++++ > tools/virsh-domain-monitor.c | 66 +++++- > tools/virsh.pod | 22 +- > 20 files changed, 1060 insertions(+), 120 deletions(-) > I updated the .pod file to have the I<--period> and pushed the remaining patches. Thanks for the reviews, John -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list