On 06/21/2013 07:37 PM, John Ferlan wrote: > On 06/19/2013 12:47 PM, Roman Bogorodskiy wrote: >> Implementation uses SIOCIFCREATE2 and SIOCIFDESTROY ioctls. >> Also, drop static virNetDevSetupControl() as we have >> public one avialable now. > > > Dropping the static/local virNetDevSetupControlFull() and > virNetDevSetupControl() seems to have triggered another side effect with > my daily Coverity build which uses "./autogen.sh --system > lv_cv_static_analysis=yes" prior to building. > > I'm not sure how else to trigger it or all > > The definition of the function is as follows: > > int virNetDevSetupControl(const char *ifname, > virIfreq *ifr) > ATTRIBUTE_RETURN_CHECK ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2); > > Thanks for pointing that out, I'll update my fix: https://www.redhat.com/archives/libvir-list/2013-June/msg00916.html Jan -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list