Re: [PATCH] use virBitmapFree instead of VIR_FREE for cpumask

[Guannan Ren <gren@xxxxxxxxxx>]

On 06/03/2013 07:11 PM, Ján Tomko wrote:
> Found by 'git grep FREE.*cpumask' after looking at 31f1f6b.
> ---
>   src/conf/domain_conf.c   | 2 +-
>   src/libxl/libxl_driver.c | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
> index 46d49a2..b335b58 100644
> --- a/src/conf/domain_conf.c
> +++ b/src/conf/domain_conf.c
> @@ -13542,7 +13542,7 @@ virDomainVcpuPinDel(virDomainDefPtr def, int vcpu)
>   
>       for (n = 0; n < def->cputune.nvcpupin; n++) {
>           if (vcpupin_list[n]->vcpuid == vcpu) {
> -            VIR_FREE(vcpupin_list[n]->cpumask);
> +            virBitmapFree(vcpupin_list[n]->cpumask);
>               VIR_FREE(vcpupin_list[n]);
>               memmove(&vcpupin_list[n],
>                       &vcpupin_list[n+1],
> diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c
> index 7245f97..bed583b 100644
> --- a/src/libxl/libxl_driver.c
> +++ b/src/libxl/libxl_driver.c
> @@ -651,7 +651,7 @@ libxlVmCleanup(libxlDriverPrivatePtr driver,
>       /* Remove any cputune settings */
>       if (vm->def->cputune.nvcpupin) {
>           for (i = 0; i < vm->def->cputune.nvcpupin; ++i) {
> -            VIR_FREE(vm->def->cputune.vcpupin[i]->cpumask);
> +            virBitmapFree(vm->def->cputune.vcpupin[i]->cpumask);
>               VIR_FREE(vm->def->cputune.vcpupin[i]);
>           }
>           VIR_FREE(vm->def->cputune.vcpupin);

   ACK

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list