On 05/17/2013 08:34 AM, Eric Blake wrote: > On 05/17/2013 08:11 AM, Daniel P. Berrange wrote: >> From: "Daniel P. Berrange" <berrange@xxxxxxxxxx> >> >> We can't use GNULIB's fprintf-posix due to licensing >> incompatibilities. We do already have a portable >> formatting via virAsprintf() which we got from GNULIB >> though. We can use to create a virFilePrintf() function. >> >> But really gnulib could just provide a 'fprintf' >> module, that depended on just its 'asprintf' module. > > I'll pursue that course of action in gnulib today; it may be a lot > simpler than forbidding fprintf throughout libvirt. Potential NACK if I > can post a gnulib solution in a timely manner. I'm still working that angle, but it's no longer timely; now that we hit rc2, any gnulib update must wait until post-release. Therefore, I've gone ahead and committed your patch for the sake of a clean mingw build for 1.0.6. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list