On 05/28/2013 09:23 PM, Eric Blake wrote: > Building with gnutls 3.2.0 (such as shipped with current cygwin) fails > with: > > rpc/virnettlscontext.c: In function 'virNetTLSSessionGetKeySize': > rpc/virnettlscontext.c:1358:5: error: implicit declaration of function 'gnutls_cipher_get_key_size' [-Wimplicit-function-declaration] > > Yeah, it's stupid that gnutls broke API by moving their declaration > into a new header without including that header from the old one, > but it's easy enough to work around, all without breaking on gnutls > 1.4.1 (hello RHEL 5) that lacked the new header. > > * src/rpc/virnettlscontext.c (includes): Include additional header. > * configure.ac (gnutls): Check for <gnutls/crypto.h>. > > Signed-off-by: Eric Blake <eblake@xxxxxxxxxx> > --- > > Pushing under the build-breaker rule, once my testing completes > across multiple systems with various gnutls versions (1.4.1 in > RHEL5, 2.12.23 in Fedora 18, 3.2.0 in Cygwin). Or not - it failed my builds. > +++ b/configure.ac > @@ -1087,6 +1087,7 @@ if test "x$with_gnutls" != "xno"; then > if test "$GNUTLS_FOUND" = "no"; then > fail=0 > AC_CHECK_HEADER([gnutls/gnutls.h], [], [fail=1]) > + AC_CHECK_HEADERS([gnutls/crypto.h]) This line needs tweaking to pre-include <gnutls/gnutls.h> before probing for crypto.h. I'll post a v2 once I complete more testing. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list