Re: [PATCH] syntax-check: ignore all quoted strings in bracket-spacing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/24/2013 03:26 AM, Ján Tomko wrote:
> Ignore strings with an escaped double quote too.
> 
> This removes the need for special handling of quotes in the
> semicolon check.
> ---
>  build-aux/bracket-spacing.pl | 13 ++++---------
>  1 file changed, 4 insertions(+), 9 deletions(-)

Hmm, our semicolon check enforces no leading spaces, but we could
probably improve it to also enforce trailing space in a for loop.  For
example, this looks odd:

src/conf/interface_conf.c:        for (i = 0; i < nbItf;i++) {

compared to

for (i = 0; i < nbItf; i++) {

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]