On 05/23/2013 10:32 AM, Michal Privoznik wrote:
> ---
>
> In case we want virsh included to these changes.
Yes, we do.
>
> tools/virsh.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/tools/virsh.c b/tools/virsh.c
> index 6f0c1ef..26d37c6 100644
> --- a/tools/virsh.c
> +++ b/tools/virsh.c
> @@ -122,9 +122,7 @@ _vshStrdup(vshControl *ctl, const char *s, const char *filename, int line)
> {
> char *x;
>
> - if (s == NULL)
> - return NULL;
> - if ((x = strdup(s)))
> + if (VIR_STRDUP(x, s) >= 0)
ACK. Wow - the 0 return value actually made sense :)
> return x;
> vshError(ctl, _("%s: %d: failed to allocate %lu bytes"),
> filename, line, (unsigned long)strlen(s));
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list